Multiple patches to lfmcmc #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 83.96% 84.00% +0.03%
==========================================
Files 42 42
Lines 2763 2769 +6
==========================================
+ Hits 2320 2326 +6
Misses 443 443 ☔ View full report in Codecov by Sentry. |
apulsipher
requested changes
Nov 25, 2024
…ld into lfmcmc-updates-nov2024
apulsipher
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of bugs. The main one: the vector containing the sampled parameters wrongly contained the first few sampled statistics. We were able to catch this with smaller samples (e.g., 10) where the differences in magnitude were more evident. In addition, it adds a couple of methods for extracting data from the LFMCMC class.
This also includes the example I wrote for @kkhader.